Jun-te Kim 7489e5ac89 Scope 21.0.0 widening to fields the skipped certs actually omit ... Review follow-up (Khalim): the first pass made far more optional than needed — notably the whole SapBuildingPart block — and a buggy 21.0.0↔21.0.1 diff also MISSED open_chimneys_count / cfl_/led_fixed_lighting_bulbs_count / suggested_ improvements, so the original change actually mapped only 3 of the 33 skipped certs (the rest still failed on open_chimneys_count). Re-derived the exact set empirically from all 33 skipped cohort certs: widen only fields that are (a) required in 21.0.0, (b) already optional in 21.0.1, AND (c) genuinely omitted by ≥1 of those certs. Result: - KEEP optional: the 4 SapWindow refinements, the top-level vent/lighting/ door/pressure-test block (incl. the 3 previously-missed fields), 2 SapEnergySource fields, Addendum.addendum_numbers, PhotovoltaicSupply. none_or_no_details, and exactly ONE building-part field (SapBuildingPart.roof_insulation_thickness — omitted by 7 certs). - REVERT to required: the other 12 SapBuildingPart fields (construction_age_ band, wall_construction, …), MainHeatingDetail.emitter_temperature, PvBatteries.pv_battery, ShowerOutlets.shower_outlet — none of the 33 certs omit these, so they stay strict. Mapper: coalesce the count fields (wet_rooms_count, open_chimneys_count, cfl_/led_fixed_lighting_bulbs_count) to 0 like every other mapper, so the now- optional values can't reach a NOT-NULL column (also drops 4 pyright ignores). Now maps 32/33 (up from 3); the last cert hits a pre-existing pv_batteries- shape AttributeError and degrades via the ADR-0031 skip path. pyright net unchanged (43, no new errors); regression test rewritten to the real omitted set. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>		2026-06-24 08:35:36 +00:00
..
tests	Sanitise millimetre-lodged full-SAP opening dimensions to metres	2026-06-16 20:16:27 +00:00
__init__.py	first draft dataclasses with loading tests	2026-04-10 11:33:17 +00:00
common.py	first draft dataclasses with loading tests	2026-04-10 11:33:17 +00:00
helpers.py	slice 10.5: PhotovoltaicArray on SAP10 schema + EpcPropertyData	2026-05-16 16:00:25 +00:00
rdsap_schema_17_0.py	Map RdSAP-Schema-17.0 certs to EpcPropertyData 🟩	2026-06-12 12:45:19 +00:00
rdsap_schema_17_1.py	Dispatch and map RdSAP-Schema-17.1 certs end-to-end 🟩	2026-06-11 12:21:17 +00:00
rdsap_schema_18_0.py	Map Not-Defined glazing code to a valid type for windowless 18.0 certs 🟩	2026-06-11 11:55:46 +00:00
rdsap_schema_19_0.py	Map RdSAP-Schema-19.0 certs to EpcPropertyData 🟩	2026-06-12 12:29:36 +00:00
rdsap_schema_20_0_0.py	fix(mapper): handle 'ND' multiple_glazing_type on RdSAP-Schema-20.0.0	2026-06-15 06:43:55 +00:00
rdsap_schema_21_0_0.py	Scope 21.0.0 widening to fields the skipped certs actually omit	2026-06-24 08:35:36 +00:00
rdsap_schema_21_0_1.py	fix(mapper): map dropped §6.1 non-separated conservatory (API)	2026-06-16 23:37:25 +00:00
sap_schema_17_1.py	Map full-SAP code-based heating systems via sap_main_heating_code 🟩	2026-06-15 14:40:59 +00:00