mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-22 08:48:38 +00:00
faf29942ba
`_secondary_fraction` keyed "has a secondary" off the integer `secondary_heating_type` code. The gov-API path surfaces the secondary as a DESCRIPTION instead (`secondary_heating.description`, e.g. "Portable electric heaters (assumed)") and leaves the integer code None. So a gas/oil boiler main (not in the §A.2.2 forced-secondary set) with an assumed portable-electric secondary dropped the secondary entirely (sec_kWh=0), under-costing the dwelling and over-rating its SAP. Per RdSAP §A.2.2 / SAP 10.2 Table 11, a lodged secondary is costed at its Table 11 fraction (cat-2 boiler = 0.10, billed at standard-rate electricity per the §A.2.2 assumed portable-electric default). New `_has_lodged_secondary_description` treats a real `secondary_heating.description` as a lodged secondary; passed to `_secondary_fraction` at both call sites. The description is authoritative — same lesson as floor_heat_loss / roof codes. (Electric-storage mains were unaffected: they force the secondary already.) Also adds the Table 11 fraction for main_heating_category=8 (electric underfloor, "Integrated storage/direct-acting electric systems" = 0.10) — the strict-raise surfaced this latent gap once cat-8 mains were routed through the lookup. Eval: 909 computed, 0 raises, 46.9% -> 47.6% within 0.5 (+13 certs: 420 -> 433), mean|err| 1.633 -> 1.586. 13 improved / 1 regressed (2610, a cat-10 room-heater cert with an independent over-count). Bucket "Portable electric heaters" median +2.73 -> ~0 on the gas/cat-2 subset (cat-7 storage was already correct). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| climate | ||
| rdsap | ||
| validation | ||
| worksheet | ||
| __init__.py | ||
| test_bre_worked_examples.py | ||
| test_calculator.py | ||
| test_pcdb_etl.py | ||
| test_pcdb_lookup.py | ||
| test_pcdb_table_322_lookup.py | ||
| test_pcdb_table_329_lookup.py | ||
| test_pcdb_table_362_lookup.py | ||
| test_postcode_weather.py | ||
| test_table_12.py | ||
| test_table_12a.py | ||
| test_table_32.py | ||