From 24edd2656b623e6f76ca7333ed3042d295ca70f2 Mon Sep 17 00:00:00 2001
From: Khalim Conn-Kowlessar <kconnkowlessar@gmail.com>
Date: Mon, 20 Apr 2026 14:19:50 +0000
Subject: [PATCH] Added user permissions ui that was missing

---
 .../settings/UsersPermissionsCard.tsx         | 20 ++++++++++++-------
 .../[slug]/(portfolio)/settings/roles.tsx     |  2 +-
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/src/app/portfolio/[slug]/(portfolio)/settings/UsersPermissionsCard.tsx b/src/app/portfolio/[slug]/(portfolio)/settings/UsersPermissionsCard.tsx
index dc2d5cf..c0e97ea 100644
--- a/src/app/portfolio/[slug]/(portfolio)/settings/UsersPermissionsCard.tsx
+++ b/src/app/portfolio/[slug]/(portfolio)/settings/UsersPermissionsCard.tsx
@@ -27,9 +27,7 @@ async function getPortfolioUsers(portfolioId: string): Promise<Collaborator[]> {
   const users = Array.isArray(json) ? json : json.users; // support both shapes
   // Guard + shape to Collaborator[]
   return Array.isArray(users)
-    ? users
-        .filter((u: any) => u.role !== "creator") // 👈 filter out creator
-        .map((u: any) => ({
+    ? users.map((u: any) => ({
           portfolioUserId: String(u.portfolioUserId),
           userId: String(u.userId),
           name: u.name ?? null,
@@ -251,12 +249,20 @@ export function UsersPermissionsCard({ portfolioId }: { portfolioId: string }) {
                           <TableCell>{c.name || "—"}</TableCell>
                           <TableCell>{c.email}</TableCell>
                           <TableCell className="min-w-40">
-                            <RoleDropdown value={c.role} onChange={(r) => onChangeRole(c.portfolioUserId, r)} />
+                            {c.role === "creator" || c.role === "admin" ? (
+                              <span className="text-xs font-medium text-gray-500 px-2 py-1 bg-gray-100 rounded-md capitalize">
+                                {c.role}
+                              </span>
+                            ) : (
+                              <RoleDropdown value={c.role as "read" | "write"} onChange={(r) => onChangeRole(c.portfolioUserId, r)} />
+                            )}
                           </TableCell>
                           <TableCell className="text-right">
-                            <Button variant="destructive" className="bg-red-700" onClick={() => onRemove(c.portfolioUserId)}>
-                              Remove
-                            </Button>
+                            {c.role !== "creator" && (
+                              <Button variant="destructive" className="bg-red-700" onClick={() => onRemove(c.portfolioUserId)}>
+                                Remove
+                              </Button>
+                            )}
                           </TableCell>
                         </TableRow>
                       ))
diff --git a/src/app/portfolio/[slug]/(portfolio)/settings/roles.tsx b/src/app/portfolio/[slug]/(portfolio)/settings/roles.tsx
index feeb223..aee553e 100644
--- a/src/app/portfolio/[slug]/(portfolio)/settings/roles.tsx
+++ b/src/app/portfolio/[slug]/(portfolio)/settings/roles.tsx
@@ -16,7 +16,7 @@ export type Collaborator = {
   userId: string; 
   name?: string | null;
   email: string;
-  role: Role;
+  role: Role | "creator" | "admin";
 };
 
 // Small role dropdown using shadcn Select