From 676ad5b10722e22beb2ec29faf9fe6debbdfa73c Mon Sep 17 00:00:00 2001
From: Khalim Conn-Kowlessar <kconnkowlessar@gmail.com>
Date: Thu, 28 May 2026 09:49:32 +0000
Subject: [PATCH] Fix lint errors blocking the Vercel build
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Escape apostrophe in the revoke-invitation ConfirmDialog description
  (react/no-unescaped-entities)
- Add role="tab" to the two tab-button arrays in PropertyDetailDrawer
  and DealPage so aria-selected is valid for that element
  (jsx-a11y/role-supports-aria-props)

The aria-selected warnings were pre-existing in those files but the
build now blocks on warnings as well as errors. The fix is the correct
ARIA pattern — these buttons are real tabs, role="tab" is what
aria-selected expects.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../[slug]/(portfolio)/settings/UsersPermissionsCard.tsx        | 2 +-
 .../(portfolio)/your-projects/live/PropertyDetailDrawer.tsx     | 1 +
 .../[slug]/(portfolio)/your-projects/live/[dealId]/DealPage.tsx | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/app/portfolio/[slug]/(portfolio)/settings/UsersPermissionsCard.tsx b/src/app/portfolio/[slug]/(portfolio)/settings/UsersPermissionsCard.tsx
index c6a07a5..bf049b6 100644
--- a/src/app/portfolio/[slug]/(portfolio)/settings/UsersPermissionsCard.tsx
+++ b/src/app/portfolio/[slug]/(portfolio)/settings/UsersPermissionsCard.tsx
@@ -589,7 +589,7 @@ export function UsersPermissionsCard({ portfolioId }: { portfolioId: string }) {
         description={
           pendingRevoke ? (
             <>
-              <span className="font-medium">{pendingRevoke.email}</span> won't
+              <span className="font-medium">{pendingRevoke.email}</span> won&apos;t
               be able to accept this invitation. You can invite them again
               later.
             </>
diff --git a/src/app/portfolio/[slug]/(portfolio)/your-projects/live/PropertyDetailDrawer.tsx b/src/app/portfolio/[slug]/(portfolio)/your-projects/live/PropertyDetailDrawer.tsx
index 9295690..789ee4d 100644
--- a/src/app/portfolio/[slug]/(portfolio)/your-projects/live/PropertyDetailDrawer.tsx
+++ b/src/app/portfolio/[slug]/(portfolio)/your-projects/live/PropertyDetailDrawer.tsx
@@ -122,6 +122,7 @@ export default function PropertyDetailDrawer({
                 {TABS.map((tab) => (
                   <button
                     key={tab}
+                    role="tab"
                     data-testid={`drawer-tab-${tab}`}
                     aria-selected={activeTab === tab}
                     onClick={() => setActiveTab(tab)}
diff --git a/src/app/portfolio/[slug]/(portfolio)/your-projects/live/[dealId]/DealPage.tsx b/src/app/portfolio/[slug]/(portfolio)/your-projects/live/[dealId]/DealPage.tsx
index 7d55cf7..95c72fa 100644
--- a/src/app/portfolio/[slug]/(portfolio)/your-projects/live/[dealId]/DealPage.tsx
+++ b/src/app/portfolio/[slug]/(portfolio)/your-projects/live/[dealId]/DealPage.tsx
@@ -220,6 +220,7 @@ export default function DealPage({
             {VALID_TABS.map((tab) => (
               <button
                 key={tab}
+                role="tab"
                 data-testid={`deal-page-tab-${tab}`}
                 aria-selected={activeTab === tab}
                 onClick={() => switchTab(tab)}