junte/assessment-model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/assessment-model.git synced 2026-07-12 13:28:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(plan-detail): read recommendations denormalised, not via plan_recommendations

Browse source 
getRecommendations read the retired plan_recommendations join table, which is
empty for new-approach plans, so the plan detail page showed no recommendations.
Read the recommendation table directly. Because recommendation.plan_id is
unindexed (26M rows), key off the plan's property_id (indexed) and filter
plan_id in memory — fast for any plan, default or not.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-06-17 14:25:41 +00:00
parent 5d87481b6b
commit a184127cd4
1 changed files with 19 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/app/portfolio/[slug]/building-passport/[propertyId]/utils.ts
View file

@ -1,6 +1,7 @@
import S3 from "aws-sdk/clients/s3";
import {
Recommendation,
recommendation,
planRecommendations,
plan,
Plan,
@ -163,23 +164,26 @@ export async function getEnergyAssessmentDocuments(
export async function getRecommendations(
planId: string
): Promise<Recommendation[]> {
const data = (await db.query.planRecommendations.findMany({
where: eq(planRecommendations.planId, BigInt(planId)),
columns: {},
with: {
recommendation: true,
},
})) as RecommendationList;
if (!data) {
throw new Error("Network response was not ok");
// Recommendations link to their plan via recommendation.plan_id (the
// plan_recommendations join table is retired). recommendation.plan_id is NOT
// indexed and the table has tens of millions of rows, so we key off the plan's
// property_id (indexed) and filter plan_id in memory. We drop already-installed
// measures, matching the previous behaviour.
const planRow = await db.query.plan.findFirst({
columns: { propertyId: true },
where: eq(plan.id, BigInt(planId)),
});
if (!planRow?.propertyId) {
return [];
}
// unnest the recommendations
// We drop measures that are already installed
const recommendations = data
.map((item) => item.recommendation)
.filter((rec) => !rec.alreadyInstalled);
const recommendations = await db.query.recommendation.findMany({
where: and(
eq(recommendation.propertyId, planRow.propertyId),
eq(recommendation.planId, BigInt(planId)),
eq(recommendation.alreadyInstalled, false)
),
});
return recommendations;
}