The Vercel build failed with "Can't resolve 'fs'" (pg-connection-string):
reporting client components transitively imported the db via the Drizzle
schema and epcSources. tsc can't see this — only bundling does.
- New schema-free pure modules: @/lib/epc/bands (EPC_BANDS + goal strings)
and @/lib/epc/labels (property-type / built-form labels).
- reporting/model.ts, EpcLadder, StockBreakdown, the PDF page and
ReportingClientArea now import bands/goals/labels from the pure modules
instead of @/lib/scenarios/model, @/app/db/schema/portfolio and
@/lib/services/epcSources.
- epcSources re-exports the label constants, so server callers are
unchanged.
- Drift guards (bands.test.ts) assert the mirrors match the schema.
tsc clean, 442 tests green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- MeasureAllocation ('where the money goes'): allocation bar by category
+ inline grouped measures table with CSV and per-measure drill-down,
replacing the old modal. Grouping is a pure TDD'd module
(lib/reporting/measures.ts) moved out of the deleted modal.
- PDF rebuilt as a print-register server component on the shared model
(buildHeadline, computeLedger figures, carsOffTheRoad): cover headline +
stats, current-vs-scenario EPC distribution, investment ledger. Screen
and report now share definitions and can't drift.
- Deleted the old gradient-era components (DashboardSummaryCards,
ScenarioFinancialDrawer, BreakdownChart, EpcQualityCards,
PlaceholderMetricCards, ReportingFunctionalityButtons,
RecommendationsOptions, ScenarioMeasuresModal, SectionDivider, scenario
selector pair) — nothing references them now.
Fixes: 'upgraded homes' KPI now deep-links to the property table (was an
invalid empty-measureType drill); measure drill-down guarded to numeric
scenarios. tsc clean, 440 tests green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Screen D (/reporting/compare): CompareClientArea runs N parallel client
calls to the existing metrics route (useQueries), rows ordered
outcome→investment→value-for-money, best-in-row marked via pickBestIndex
(TDD'd — nulls never win). Up to 4 columns; only modelled scenarios
listed (ADR-0003). Column headers link back to the scenario view.
Screen E (/reporting/data-quality): getDataQualityMetrics adds evidence
composition (in-date/expired/estimated, each home once) and band-movement
counts — likely downgrades AND the new likely-upgrades signal, both by
lodged-vs-effective band per CONTEXT.md. Page reuses the drill-down shelf
for every issue; unlock modules list columns with templates gated behind
'coming soon' pending the data-team spec.
Reporting page's Compare button and 'Review data quality' link now wired.
tsc clean, 435 tests green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replaces the old gradient-card page with the v2.3 design system (#370):
one quiet panel vocabulary, EPC colour + semantic deltas only, numbers
as the centre. New components under reporting/components/:
- ScenarioCombobox: searchable, Current stock + Recommended plans pinned,
unmodelled scenarios disabled with 'Awaiting modelling' (ADR-0003)
- KpiBand: current-stock (incl. energy use) and scenario before/after
with semantic deltas via shapeKpiDelta
- EpcLadder: statutory band colours, estimated share, navy scenario overlay
- GoalCallout: goal-aware, per selectGoalCallout (portfolio goal on current
stock, scenario goal on scenario view)
- InvestmentLedger: canonical gross/net, cost tooltips, car equivalents
- FilterChips: inline hide-non-compliant / compliance-window / lodged
toggles, EPC-only, apply immediately (no popover)
- DrillDownShelf: full-width, wired to /reporting/properties, deep links
- StockBreakdown, ConfidenceStrip
Page now loads portfolio goal + listScenariosWithStatus. Old components
retained only for the not-yet-rebuilt PDF route. tsc clean, 431 tests green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Metrics route (#370): net_cost/gross_per_unit now use computeLedger's
all-in definitions (was construction−funding, delivery/contingency
excluded); adds ADR-0010 complianceBand+complianceDate params (validated,
lodged-only membership, applied at all four query sites, scenario-side
only); renames useOriginalBaseline → useLodgedBaseline reading lodgedSapSql
with a keep-on-unknown COALESCE so new-approach homes aren't dropped.
New drill-down endpoint /reporting/properties: one filter per request
(band/estimated/expired/likely-downgrade/likely-upgrade/measure),
paginated, powering Screen C and the CSVs. Band-movement filters use the
certificate-gated lodgedEpcBandSql per CONTEXT.md.
Reporting page swaps the thin local getScenarios for
listScenariosWithStatus (config + derived modelled state, ADR-0003).
Route tests on the mocked-db pattern; full suite 430 green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Gross/Net cost, Project delivery, Current stock, Likely downgrade/upgrade
(band movement) added to CONTEXT.md from the reporting-redesign grilling
session. ADR-0010 records the compliance-window filter as a report-view
parameter, not a Scenario constraint. Also commits the previously
untracked ADR-0001/0002 docs.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
invalidateQueries only refetches mounted queries; the property table isn't
mounted on the add page, and useProperties' refetchOnMount: false then
suppresses the refetch when it does mount — so the invalidation never
produced a fetch. Removing the cached query instead guarantees the initial
fetch on mount.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Both mutations navigated with router.push alone, so the destination served
the pre-mutation render from the client router cache: new properties were
missing from the portfolio table (compounded by useProperties' 5-minute
staleTime, now invalidated too) and a first scenario still showed
"No scenarios yet". router.refresh() after push busts the cache.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Post-review UX feedback on the run journey:
- The post-trigger card computed its ETA from the just-cleared scenario
selection, so it always promised "~5 minutes" whatever the run size.
ETA now comes from the captured run (estimateRunMinutes, TDD'd) and the
done state is a compact status banner above a still-visible Recent runs
table, which polls every 5s while a run is moving (historyRefetchInterval,
TDD'd) — trigger, glance, leave.
- The only way back was a text-xs gray-400 breadcrumb (~2.5:1, sub-AA);
replaced with an accessible "← Back to {portfolio}" link.
- "Remove all filters" button on Step 2.
- Scenario rows were a checkbox nested inside a button (state invisible to
screen readers); now a label wrapping a real checkbox.
- Large-run confirm lists the scenario names and selection being committed,
is labelled, closes on Escape, and starts focus on "Go back".
- Postcode filter no longer fails silently: loading and error-with-retry
states.
- Run status "Dispatched" reads "Starting up"; scenarios page gains a
"Run modelling" entry point.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Card and folder menus move to Headless UI v2 (Menu / Popover with
anchor positioning): panels portal to the top layer so the list view
can't clip them, and Esc, outside-click close, arrow-key nav, and menu
semantics come from the primitive — replaces the details/summary menus
and the fixed-position workaround. The folder popover hosts the
two-step remove confirm. Cards and table rows are draggable onto rail
targets (folder = file, Starred = star, All portfolios = unfile) with
drop highlighting; folder-reorder drag is type-guarded from card drags.
Selected rail view persists in the URL via replaceState (?folder=id /
?view=starred), read by the server component; unknown folder ids fall
back to All, and deleting the folder being viewed returns to All.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Impeccable critique (25/40) fixes: window.confirm replaced by a
two-step confirm inside the folder menu (states the unfile consequence,
red confirm takes focus, Escape cancels); mutation failures now render
a dismissible notice as well as the live region, and folder-create
errors are no longer swallowed; list-view card menu uses fixed
positioning measured on open so the table's overflow container can't
clip it; Escape closes card/folder menus with focus returned. Also:
search placeholder and rail-count contrast to >=4.5:1, folder-menu and
New-folder hit targets to >=24px, th scope=col, decorative ticks
aria-hidden, rename input regains a visible focus state.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Folder removal now confirms with copy stating portfolios are unfiled,
not deleted. Grid/list preference persists in a cookie read by the
server component, so the chosen view renders on first paint. Long lists
render the first 24 rows with a show-more button; the reveal count
resets when the view or search changes, and starred float keeps pinned
work on the first screen.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Phase 4: the portfolio landing page now renders the property table directly.
UPRN matching is confirmed during onboarding, so properties arrive matched and
the post-onboarding "Unmatched" tab is no longer needed (tab components left in
place pending a legacy-no-UPRN reconciliation follow-up).
Phase 5: AddressesPanel labels the new "low_score" status "Low-confidence match".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
At awaiting_review, when address2uprn flagged rows, OnboardingProgress now
shows two tabs: Classification (existing verify/unknown/ordering panels) and
Addresses. The Addresses tab (AddressesPanel) lists each flagged combiner row
with the OS Places matcher (reused search → residential candidates) and a
"No UPRN" action, saving corrections via useSaveUprnCorrection. Finalise is
gated on unresolvedAddresses === 0 with a matching disabled reason; the tab
carries a badge of the unresolved count.
tsc --noEmit clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Client page driven by useQuery on /api/me/portfolio-home with optimistic
mutations (star, move-to-folder, folder create/rename/delete, drag or
menu-based reorder). TDD'd view-model in portfolioHomeView.ts (status
pill mapping, search over display language, sort incl needs-attention,
money/date formatting, optimistic config upsert);
groupPortfoliosForHome generalised over id type so the client re-groups
with wire-format string ids. List view is a semantic table; replaces
CardTiles/Card/AddNewCard (NewPortfolioModal retained).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dispatchFinaliser now:
- blocks (before the CAS claim) when any flagged combiner row is still
unresolved -> new "unresolved_addresses" outcome; finalize route returns 409.
- overlays the user's confirmed UPRNs onto the combiner CSV (buildConfirmedCombinerUri
writes a sibling .confirmed.csv) and points the finaliser at it, so a confirmed
UPRN drives identity + property_overrides in one pass. No corrections -> original
URI unchanged.
tsc --noEmit clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Server module + two routes for the pre-finalise Addresses tab:
- getFlaggedAddresses: reads the combiner CSV from combinedOutputS3Uri,
returns rows address2uprn could not confidently match (empty UPRN or a
non-"matched" status), joined with any saved correction.
- upsertUprnCorrection: upserts a confirmed UPRN / no-UPRN per source_row_id.
- GET .../address-matches, POST .../address-corrections (thin, auth-guarded).
tsc --noEmit clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Scenario 1275's modelling run crashed the engine: its exclusions carried
'room_roof_insulation', which isn't a backend MeasureType — the strict
_parse_exclusions raises for every property in the scenario. The authoring
vocabulary had seven such tokens (room_roof_insulation, boiler_upgrade,
secondary_heating, ventilation, fireplace, hot_water_tank_insulation,
cylinder_thermostat).
Scenario authoring now uses its own SCENARIO_MEASURES vocabulary — exactly
the backend MeasureType set (drifted names corrected, unimplemented
measures dropped, missing system_tune_up/_zoned + sloping_ceiling gained),
pinned by a test that fails if either side moves alone (the backend's
ADR-0056 shared-contract rule, applied app-side). room_roof_insulation
leaves DISRUPTIVE_MEASURES until the backend implements the measure;
legacy tokens on existing rows still display in constraint summaries.
The global measuresDisplayLabels vocabulary (recommendations display, old
file-based trigger) is untouched.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Foundation for the "Addresses" review tab: captures the user's confirmed
UPRN per combiner row, keyed by source_row_id (no property.id exists
pre-finalise). At dispatchFinaliser these are overlaid onto the combiner
CSV so the finaliser builds identity + property_overrides from the
confirmed UPRN in one pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
TDD'd pure planning core (planFolderReorder with payload validation,
groupPortfoliosForHome with starred float + recency, planFolderDeletion
encoding unfile-then-delete, buildStarChange owning starred_at-as-flag),
applied by thin route handlers: folder create/rename/delete/reorder,
per-portfolio config upsert, and the grouped home read.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Design references and critique snapshot for the portfolio home redesign;
impeccable design skill added to devcontainer postCreateCommand on trial.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Per-user portfolio workspace layer for the home-page redesign: starred
portfolios (starred_at, non-null = starred, orderable) and personal
folders (name + position, drag-reorderable). Composite FK
(folder_id, user_id) -> (id, user_id) makes cross-user folder
assignment impossible at the database level. Config rows are created
lazily via upsert on (user_id, portfolio_id); portfolioUsers remains
pure access control.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The BulkUploadComingSoonModal (drag/drop upload, template download, header
validation → creates the upload and routes into the map-columns onboarding
step) existed but was never wired to anything. The "Bulk excel import" menu
item routed to the uploads list instead. Point it at the dialog so the bulk
upload onboarding starts from there.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The address2uprn lookup already returns the EPC certificate number
alongside the UPRN, but only the UPRN is persisted today. This adds
a nullable column so a follow-up change can start saving it.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- MatchAddress: long OS addresses overflowed the candidate row (text column
wasn't width-constrained). Give it min-w-0 flex-1 and truncate both lines
(full address on hover) so the dialog layout holds.
- PortfolioTabs: when nothing is unmatched, render just the properties table
with no tab strip (the "Needs attention" tab only appears when count > 0).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Turns the "Needs attention" tab into an actionable per-property match flow:
edit the address, confirm the postcode, search Ordnance Survey, and pick from
the RESIDENTIAL addresses in that postcode. Every candidate is a real OS
address, so picking one assigns a guaranteed valid, residential UPRN — the
property then leaves the tab and joins the main table.
- MatchAddress dialog: postcode search + residential-only candidate list
(non-residential filtered out; already-in-portfolio shown but non-selectable,
each row shows its UPRN). Replaces the edit-only EditAddress.
- PATCH /properties/[propertyId]: assigns uprn + address + postcode (user input
kept as the fallback); (portfolio_id, uprn) clash → friendly 409.
- client.ts: searchAddresses() + useAssignUprn().
Reuses the existing /properties/search endpoint, which read-through caches OS
Places results per postcode in postcode_search (30-day TTL) — repeat searches
of the same postcode hit our DB, not the OS API (surfaced as a "from cache"
hint in the dialog). No backend trigger needed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reworks the separation from a card stacked above the table into a proper
second tab, and takes unmatched properties out of the main list entirely:
- PortfolioTabs: "Properties" | "Needs attention" tab shell with a count badge
on the second tab. Both panels stay mounted (hidden with CSS) so the main
table keeps its filter/pagination state across tab switches.
- getProperties / getPropertiesCount now exclude uprn IS NULL, so unmatched
properties no longer appear (or count) in the main table until resolved.
(Both functions are only used by the main table's /api/properties route.)
- UnmatchedProperties: lives in the tab; shows an "all matched" empty state
instead of rendering nothing, and copy updated for the edit-only scope.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Add-properties menu had "Bulk excel import" disabled behind a "Soon" badge.
The bulk-upload flow exists (/portfolio/[id]/bulk-upload), so make the item
clickable and route to it, matching the "Search by postcode" item.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- The run's config now lives on the task row's new `inputs` column
(migration PR #361) instead of a config subtask — sub_tasks belong
entirely to the distributor's execution work.
- Distributor path corrected to /v1/modelling/trigger-run.
- Sub-task granularity is batches, not properties: history shows progress
as a percentage under the status chip; the Plans column always shows the
plan count (batch counts are never comparable to property/plan numbers).
- ADR-0008 amended accordingly.
Live verification of the task write waits for PR #361 to be applied.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Opening the building passport of an unmatched property 500'd: the whole page is
UPRN-keyed and getSpatialData did BigInt(propertyMeta.uprn) with a null uprn
("Cannot convert null to a BigInt"). Since a property with no UPRN has no
spatial data, installed measures, or EPC to show, render a clear "not matched
yet" state with a link back to the portfolio instead of crashing.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mirrors sub_task.inputs (JSON as text): the task's request inputs. For a
modelling run (ADR-0008, feature/bulk-trigger-modelling) the task row itself
carries the run's config — portfolio id, scenario ids, filters — with
sub_tasks holding the per-property execution work. Column-only change so it
can be applied to the database ahead of the feature merging.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Each unmatched-property row now opens a small dialog to correct its address and
postcode, saved via a new endpoint. UPRN matching (the address search) is left
for a later change — this only fixes the address text so the record is right
before matching.
- PATCH /api/portfolio/[portfolioId]/properties/[propertyId]: auth + zod,
updates address/postcode scoped by (property, portfolio).
- properties/client.ts: useUpdateAddress() mutation.
- EditAddress: the edit dialog; on save the page re-fetches (router.refresh)
so the row reflects the new values.
- UnmatchedProperties: row action swapped from the placeholder to the live
Edit dialog; portfolioId threaded through from the page.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The distributor gets {task_id, portfolio_id, scenario_ids, filters} only —
previewed count and triggered_by are app provenance, already durable on the
config subtask keyed by the same task_id.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
