From 3c0f395c9b1f145575d75c143df5306de49a5e3c Mon Sep 17 00:00:00 2001 From: Jun-te Kim Date: Wed, 19 Mar 2025 15:44:14 +0000 Subject: [PATCH 1/3] make uprn optional --- etl/transform/types.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etl/transform/types.py b/etl/transform/types.py index cefb894..f8fe9e6 100644 --- a/etl/transform/types.py +++ b/etl/transform/types.py @@ -24,7 +24,7 @@ class CompanyInfo(BaseModel): class SurverySummaryInfo(BaseModel): reference_number: str epc_language: str - uprn: str + uprn: Optional[str] = "" postcode: str region: str address: str From e6478f9b3860453902087cc3a76be8b740538784 Mon Sep 17 00:00:00 2001 From: Jun-te Kim Date: Wed, 19 Mar 2025 15:44:53 +0000 Subject: [PATCH 2/3] uprn --- etl/transform/types.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etl/transform/types.py b/etl/transform/types.py index f8fe9e6..896fc4f 100644 --- a/etl/transform/types.py +++ b/etl/transform/types.py @@ -29,7 +29,7 @@ class SurverySummaryInfo(BaseModel): region: str address: str town: str - county: Optional[str] = None + county: Optional[str] = "" property_tenure: str transaction_type: str inspection_date: datetime From 4c3a8b154babb573acd92c9d29fc88971dd0a957 Mon Sep 17 00:00:00 2001 From: Jun-te Kim Date: Wed, 19 Mar 2025 15:48:16 +0000 Subject: [PATCH 3/3] add artificats --- .github/workflows/scis_invoice_calculator.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/scis_invoice_calculator.yml b/.github/workflows/scis_invoice_calculator.yml index 49a5ae3..140bc2f 100644 --- a/.github/workflows/scis_invoice_calculator.yml +++ b/.github/workflows/scis_invoice_calculator.yml @@ -30,4 +30,9 @@ jobs: SGEC_SERVICE_SHAREPOINT_ID: ${{ secrets.SGEC_SERVICE_SHAREPOINT_ID }} SHAREPOINT_CLIENT_ID: ${{ secrets.SHAREPOINT_CLIENT_ID }} SHAREPOINT_CLIENT_SECRET: ${{ secrets.SHAREPOINT_CLIENT_SECRET }} - SHAREPOINT_TENANT_ID: ${{ secrets.SHAREPOINT_TENANT_ID }} \ No newline at end of file + SHAREPOINT_TENANT_ID: ${{ secrets.SHAREPOINT_TENANT_ID }} + - name: Upload Excel file + uses: actions/upload-artifact@v4 + with: + name: my-excel-file + path: survey_data.xlsx \ No newline at end of file