From 8ee0a236f909ae94a47edc894b9ff80eec07b4b6 Mon Sep 17 00:00:00 2001 From: Jun-te Kim Date: Mon, 31 Mar 2025 10:37:14 +0000 Subject: [PATCH] finsihed writing floor area, add more test as I need them@ --- .github/workflows/scis_invoice_calculator.yml | 2 +- .github/workflows/sharepoint_validator.yml | 2 +- etl/tests/test_pre_site_note_class.py | 9 ++++----- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/scis_invoice_calculator.yml b/.github/workflows/scis_invoice_calculator.yml index 6e69f04..66a5461 100644 --- a/.github/workflows/scis_invoice_calculator.yml +++ b/.github/workflows/scis_invoice_calculator.yml @@ -1,7 +1,7 @@ name: SCIS Invoice Calculator on: schedule: - - cron: '0 9 * * *' + - cron: '0 6 * * *' workflow_dispatch: jobs: diff --git a/.github/workflows/sharepoint_validator.yml b/.github/workflows/sharepoint_validator.yml index a9b4d42..bc22bee 100644 --- a/.github/workflows/sharepoint_validator.yml +++ b/.github/workflows/sharepoint_validator.yml @@ -1,7 +1,7 @@ name: SharePoint Validator on: schedule: - - cron: '0 9 * * *' + - cron: '0 6 * * *' workflow_dispatch: jobs: diff --git a/etl/tests/test_pre_site_note_class.py b/etl/tests/test_pre_site_note_class.py index 2fddd52..58cf3e7 100644 --- a/etl/tests/test_pre_site_note_class.py +++ b/etl/tests/test_pre_site_note_class.py @@ -4,7 +4,7 @@ from etl.surveyedData.surveryedData import surveyedDataProcessor from etl.db.db import get_db_session, init_db from etl.transform.types import AssessorInfo import pytest - +from etl.jjc_invoice import work_out_total_floor_area @pytest.fixture(scope="module") def pre_site_note_path(): @@ -23,7 +23,6 @@ def test_assessor_accreditation(local_survey): def test_floor_area_calculator(local_survey): # Floor area is important to work out invoice, make a test to work out invoice correctly - raise NotImplementedError("Yo - junte do some work here") - - - + area = work_out_total_floor_area(local_survey.pre_site_note) + assert area == ('73-97m', 91) + \ No newline at end of file