junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
7862 commits 49 branches 0 tags 224 MiB
Commit graph

7862 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jun-te Kim
daa1cd7967 feat(address2uprn): withhold ambiguous cross-row UPRN matches (ADR-0057) 
Phase 1 of confirming UPRNs before finalise. address2uprn matched each
row independently, so one UPRN could be the best match for two distinct
addresses (a coarse EPC record absorbing several real addresses, e.g.
flats in a block). Those distinct addresses were then silently merged by
the property identity insert, and collided in property_overrides.

resolve_group_ambiguity() withholds a UPRN claimed by >=2 distinct
normalised addresses within a postcode group (keeps genuine same-address
re-listings), and the handler now emits an address2uprn_status column
(matched | ambiguous_duplicate | unmatched | invalid_postcode | error).
Withheld rows drop to a null UPRN but keep their lexiscore for triage on
the (upcoming) confirmation page.

Also adds the ADR-0057 backstop dedup in property_overrides upsert_all so
the ON CONFLICT statement can never double-touch a row.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-07-07 15:15:59 +00:00
Daniel Roth
66b2df99e9
Merge pull request #1482 from Hestia-Homes/feature/abri-api-integration 
Abri API Integration: lambda handler and plumb everything together
 2026-07-07 15:46:50 +01:00
Daniel Roth
c0e444fccb abri_api not abri 2026-07-07 14:40:33 +00:00
Daniel Roth
1085384f21 Merge branch 'main' into feature/abri-api-integration 2026-07-07 14:08:52 +00:00
Daniel Roth
f5059c0589 tf comment 2026-07-07 14:04:34 +00:00
KhalimCK
9ff4de0563
Merge pull request #1481 from Hestia-Homes/feature/modelling-trigger-run 
Modelling Run Distributor: POST /v1/modelling/trigger-run
 2026-07-07 14:36:45 +01:00
Khalim Conn-Kowlessar
cc4bf4394e Both postcode batchers share one group-preserving packing core 🟪 
Review feedback (#1481): the address batcher and the Modelling Run batcher
implemented the same greedy packing; the core moves to
utilities/grouped_batching.py and both become thin wrappers.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 13:24:02 +00:00
Daniel Roth
04b32b1515 minor refactor 2026-07-07 13:21:01 +00:00
Daniel Roth
7b6c7e1168 remove bad import 2026-07-07 13:19:03 +00:00
Daniel Roth
252a146cc3 remove silly comment 2026-07-07 13:17:24 +00:00
Daniel Roth
3934e2d359 move trigger check to HubspotDealDiffer 2026-07-07 13:15:40 +00:00
Daniel Roth
d9b441962f Name the Abri trigger builder for its None-or-message contract 🟪 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 13:02:25 +00:00
Daniel Roth
c016c8b754 Extract _trigger_abri_lambda for consistency with the other scraper triggers 🟪 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:58:48 +00:00
Khalim Conn-Kowlessar
07190fc332 Legacy property columns no longer resolve type or built form 🟩 
ADR-0056 amended: override and EPC own type/form facts; a property with
neither is Unknown whatever the legacy columns say. Mirror columns removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:52:11 +00:00
Khalim Conn-Kowlessar
ddd64a9297 Legacy property columns no longer resolve type or built form 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:49:19 +00:00
Daniel Roth
7ad0dc0595 Merge branch 'main' into feature/abri-api-integration 2026-07-07 12:46:17 +00:00
Daniel Roth
a3985389ab The deal row names the job number client_booking_reference, matching HubSpot and the schema 🟪 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:43:40 +00:00
Daniel Roth
5286e2a2a2 The job number is stored in the client_booking_reference column 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:31:07 +00:00
Khalim Conn-Kowlessar
60c448e66d FastAPI Lambda can send to the modelling_e2e queue 
Remote state + MODELLING_E2E_SQS_URL env var + send policy ARN, and
fast_api_lambda deploys after modelling_e2e_lambda so the remote state
exists before it applies.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:18:48 +00:00
Khalim Conn-Kowlessar
bf8647c9b5 The 409 guard and batch creation read as methods on ModellingRunTasks 🟪 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:16:42 +00:00
Khalim Conn-Kowlessar
b62901a9de The distributor coexists with both table stacks and mounts at /v1/modelling 🟪 
DB access via parameterised SQL, not the infrastructure SQLModel mirrors:
importing those alongside the legacy backend.app.db.models mirrors of the
same tables double-registers them in the shared metadata and crashes the
app at import. Contained to the modelling package until the DDD cut-over.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:15:31 +00:00
Khalim Conn-Kowlessar
b22b9cbca0 Scenarios outside the portfolio refuse the run 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:06:42 +00:00
Khalim Conn-Kowlessar
ca799cc5e5 Scenarios outside the portfolio refuse the run 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:06:02 +00:00
Khalim Conn-Kowlessar
e9eb068be9 Filters that match no properties refuse the run 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:05:39 +00:00
Khalim Conn-Kowlessar
e9b39df322 Filters that match no properties refuse the run 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:05:03 +00:00
Khalim Conn-Kowlessar
cfedb8e9cf A task that already has sub_tasks refuses re-distribution 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:04:34 +00:00
Khalim Conn-Kowlessar
dade7a3a5f A task that already has sub_tasks refuses re-distribution 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:04:05 +00:00
Khalim Conn-Kowlessar
9031c16ba7 Trigger-run fans out one sub_task and message per scenario batch 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:03:33 +00:00
Khalim Conn-Kowlessar
489e2b5d47 Trigger-run fans out one sub_task and message per scenario batch 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:02:12 +00:00
Khalim Conn-Kowlessar
7606480338 An oversized postcode becomes its own batch 🟩 
Behavior emerged from the packing rule — pinned straight to green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 12:00:07 +00:00
Khalim Conn-Kowlessar
2dd948259f Batches never split a postcode 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:59:07 +00:00
Khalim Conn-Kowlessar
80c474b37b Batches never split a postcode 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:58:41 +00:00
Khalim Conn-Kowlessar
bf0d630a8f An attach-mode partial failure persists successes then records the failure 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:56:57 +00:00
Khalim Conn-Kowlessar
3cf44d6409 An attach-mode partial failure persists successes then records the failure 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:55:49 +00:00
Khalim Conn-Kowlessar
7709518431 An attach-mode batch models under the supplied sub_task without children 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:53:26 +00:00
Khalim Conn-Kowlessar
b840af11de An attach-mode batch models under the supplied sub_task without children 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:52:45 +00:00
Khalim Conn-Kowlessar
f317233939 A recorded batch failure does not return the message to SQS 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:51:23 +00:00
Khalim Conn-Kowlessar
52b07e3ea4 A recorded batch failure does not return the message to SQS 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:50:38 +00:00
Daniel Roth
3b9b558628 The job number is stored in the client_booking_reference column 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:50:10 +00:00
Khalim Conn-Kowlessar
c64bd8fd85 A recorded batch failure carries structured details onto the sub_task outputs 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:50:10 +00:00
Khalim Conn-Kowlessar
8a3c0f3e77 A recorded batch failure carries structured details onto the sub_task outputs 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:49:56 +00:00
Khalim Conn-Kowlessar
f01131a064 A batch message with task_id and subtask_id attaches to the app-owned task 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:48:53 +00:00
Khalim Conn-Kowlessar
ca6ca2a220 A batch message with task_id and subtask_id attaches to the app-owned task 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:47:20 +00:00
Daniel Roth
55baddfd9e A local smoke drives HubSpot-to-write-back LogJob with only the Abri edge stubbed 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:47:03 +00:00
Daniel Roth
481c01098d Real Abri portal deals fire the job-logging trigger 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:46:33 +00:00
Khalim Conn-Kowlessar
19d9e758ad Both filterable components resolve through one precedence engine 🟪 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:45:10 +00:00
Daniel Roth
eaedd9a63d Real Abri portal deals fire the job-logging trigger 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:44:51 +00:00
Khalim Conn-Kowlessar
513977a6fd Filters combine with AND 🟩 
Behavior emerged from filter composition — pinned straight to green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:43:51 +00:00
Khalim Conn-Kowlessar
fc3f6a6f94 Built-form filter resolves with the same precedence as property type 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:43:03 +00:00
Khalim Conn-Kowlessar
d56079a1d4 Built-form filter resolves with the same precedence as property type 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 11:42:14 +00:00