mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
193ae27124
RdSAP10 `wall_construction == 6` is canonically WALL_SYSTEM_BUILT, but the gov-EPC basement heuristic hijacked it: Elmhurst lodges both "SY System build" and "B Basement wall" as code 6, so a system-built wall was mis-flagged `main_wall_is_basement` and routed to the RdSAP §5.17 `u_basement_wall` override instead of the system-built U-value table. System-built stays on its canonical code 6; the basement signal moves to an explicit `is_basement` (SapAlternativeWall) / `wall_is_basement` (SapBuildingPart) Optional[bool] flag, set by the Elmhurst mapper from the distinct "SY"/"B" codes via `_elmhurst_wall_is_basement` (True for B, False for SY, None otherwise). The `main_wall_is_basement` / `is_basement_wall` properties honour the flag when set and fall back to the gov-EPC API code-6 heuristic when None — so the API path (basement lodged as integer 6, no flag) and the cert 000565 "B" cohort are unchanged. Acceptance (a recommendation-summary generator depends on it): a system-built MAIN wall reports wall_construction == 6 AND main_wall_is_basement is False; a genuine basement main wall still reports main_wall_is_basement is True. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| applications | ||
| domain | ||
| infrastructure | ||
| orchestration | ||
| repositories | ||
| utilities | ||
| __init__.py | ||
| conftest.py | ||
| test_lambda_packaging.py | ||