19e23d0c31
Extends `_elmhurst_main_heating_category` in `datatypes/epc/domain/mapper.py` so a PCDB index that resolves to a Table 362 record (heat pumps only) yields category 4 — the SAP 10.2 Table 4a code that gates the Appendix N3.6/N3.7 heat-pump cascade (`cert_to_inputs.py` lines 1896, 2005, 2057, 2104 all branch on `main_heating_category == 4`). Authoritative signal: PCDB Table 362 is heat-pumps-only, so membership IS the heat-pump answer. `heat_pump_record(pcdb_id)` (introduced for the API path's cohort closure) returns the typed record or None; a non-None return is sufficient. No fuel-type belt-and-braces is needed — Table 362 membership is unambiguous, unlike the gas-boiler branch which uses fuel type to disambiguate PCDB Table 105 records. Forcing function (Slice S0380.1): cert 0380 Summary cascade SAP moves from 33.7920 (Δ -54.7184) to 81.7528 (Δ -6.7576) — closes ~88% of the gap. Remaining -6.76 SAP is the next workstream: cylinder / HW cascade, PV array surfacing, secondary-heating routing (per HANDOVER_CERT_0380_SUMMARY_PATH.md debug order steps 3–4). Added focused unit test `test_summary_0380_main_heating_category_is_heat_pump` that pins the contract at the mapper boundary (idx 104568 → category 4), so future debuggers can localise regressions before walking the full chain. Architectural note: introduces the first `datatypes/epc/domain/mapper.py → domain/sap10_calculator/tables/pcdb` import. PCDB is BRE reference data shared by both layers; treating it as importable shared reference is the lighter alternative to either (a) duplicating an HP-PCDB-IDs frozenset in the mapper or (b) hoisting PCDB into a new shared package. Pyright baseline preserved: datatypes/epc/domain/mapper.py: 32 errors (no new errors introduced) backend/documents_parser/tests/test_summary_pdf_mapper_chain.py: 0 errors Regression suite: 670 pass + 11 fail (vs handover baseline 669 + 10 — net +1 pass for the new GREEN unit test, +1 fail still being the Slice 1 chain test that this slice does not yet fully close). Spec refs: - SAP 10.2 Table 4a (main heating category codes — code 4 = heat pump) - SAP 10.2 Appendix N3.6/N3.7 (heat-pump space-heating efficiency with PSR interpolation, routed via the category-4 gate) - BRE PCDB Table 362 (heat-pump records — pcdb_id 104568 = Mitsubishi Ecodan PUZ-WM50VHA, the cert 0380 main heating appliance) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .devcontainer | ||
| .github/workflows | ||
| .idea | ||
| .vscode | ||
| applications | ||
| asset_list | ||
| backend | ||
| backlog | ||
| datatypes | ||
| deployment/terraform | ||
| docs/adr | ||
| domain | ||
| epr_data_exports | ||
| etl | ||
| infrastructure | ||
| model_data/requirements | ||
| orchestration | ||
| recommendations | ||
| repositories | ||
| scripts | ||
| sfr/principal_pitch | ||
| survey_report | ||
| tests | ||
| utilities | ||
| utils | ||
| .coveragerc | ||
| .dockerignore | ||
| .gitignore | ||
| __init__.py | ||
| ara_backend_design.md | ||
| BaseUtility.py | ||
| CLAUDE.md | ||
| conftest.py | ||
| CONTEXT.md | ||
| devcontainer.sh | ||
| Dockerfile.test | ||
| Dockerfile.test.dockerignore | ||
| Makefile | ||
| MEMORY.md | ||
| package-lock.json | ||
| package.json | ||
| pyproject.toml | ||
| pyrightconfig.json | ||
| pytest.ini | ||
| README.md | ||
| run_lambda_local.sh | ||
| serverless.yml | ||
| test.requirements.txt | ||
| tox.ini | ||
| UBIQUITOUS_LANGUAGE.md | ||
Model Repository
This repository contains the code pertaining to the development of the data science and machine learning products being utilised by Hestia.
The different folders in this repository relate to services that can be used independently, or can be imported and used as part of a larger application
Getting Started
Prerequisites
Dev Container Setup
This repo uses a Docker Compose-based dev container. The model-backend service joins a shared-dev Docker network so it can communicate with other local services (e.g. a frontend container) running on your machine.
VS Code users: The initializeCommand in devcontainer.json creates the shared-dev network automatically before the container starts. No manual step required — just open the repo and select Reopen in Container.
Non-VS Code / CI workflows: Run the following once before starting the container:
make dev-setup
This is idempotent and safe to re-run if the network already exists.
Folders
backend/
This folder contains the code for the fastapi backend service, which provides an interface to much of the functionality in this repository, for the frontend
model_data/
This folder contains related to the reading and preparation of assessment model data, including pulling out epc attributes
Testing
All tests can be run, against the configuration in pytest.ini running
pytest
This will run the complete panel of tests and report on coverage in the locations specified by the pytest.ini file.
To run tests in a specific service, e.g. inside of model_data, simply run
pytest --cov-config=model_data/.coveragerc --cov=model_data
This will produce the test results and coverage reports