Contains projects associated to the development of modeling products
Find a file
Khalim Conn-Kowlessar 29cfdf6461 Slice S0380.11: resolve zero-shower lodgings to count=0 (closes cert 2225)
Cert 2225-3062-8205-2856-7204 lodges **zero showers** in its Summary
§1x Baths and Showers block. The Summary mapper at
`mapper.py:3536-3537` predicated the shower-count assignment on
`has_electric_shower`: for cohort certs with no electric shower the
counts collapsed to None — but cert 2225 has no showers at all, and
the cascade's None-handling defaults to 1 mixer shower (over-counting
HW kWh by ~66 against the worksheet (64)/(216) target).

Same disposition the API path received in slice 102f-prep.8 (commit
1d5183c6, "API mapper resolves shower_outlets=None → 0 mixers") —
extending it to the Summary mapper.

Scope-limited fix: zero-shower lodgings resolve to **explicit 0**
counts (not None) so the cascade does not default-assume a mixer.
Non-zero shower lodgings keep their existing convention (None for
non-electric → cascade derives count from `shower_outlets`) so the 5
boiler-cohort hand-built parity tests
(`test_from_elmhurst_site_notes_matches_hand_built_*`) stay GREEN.

Forcing function: cert 2225 first-attempt Summary SAP closes from
Δ -0.3079 to Δ **+0.0441** — within the ±0.07 ASHP-cohort spec floor.

Cohort closure status (5 of 7 ASHP certs now at spec floor):
  cert  Δ vs worksheet  spec floor?
  0380  +0.0594         ✓
  0350  +0.0458         ✓
  2225  +0.0441         ✓  ← this slice
  2636  +0.4873         ✗  (cantilever + alt-wall; next slice)
  3800  +0.0442         ✓
  9285  +0.0502         ✓
  9418  +2.5973         ✗  (Daikin EDLQ05CAV3, distinct PCDB)

Added two tests:
- `test_summary_2225_no_showers_lodged_resolves_to_zero_counts` —
  unit-level pin that no-shower lodgings produce explicit 0 counts.
- `test_summary_2225_full_chain_sap_within_spec_floor_of_worksheet`
  — Layer-4 chain test at ±0.07.

Pyright net-zero on both edited files (mapper.py 32 baseline).

Regression suite: 682 pass + 10 fail (handover baseline 669 + 10 +
13 new GREEN tests across S0380.2..S0380.11). The 5 boiler hand-
built parity tests confirmed still GREEN — the refinement
deliberately preserves their convention by only flipping the zero-
shower case.

Spec refs:
- Slice 102f-prep.8 (commit 1d5183c6) — API-path precedent.
- SAP 10.2 Appendix J — shower energy accounting (electric vs mixer
  routing); mixer showers draw from the HW system and contribute to
  HW kWh; electric showers are §J line 64a (separate energy stream).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-06-01 16:28:46 +00:00
.devcontainer pr review, move domain and orhcestration 2026-06-01 14:00:31 +00:00
.github/workflows added landlord description overrides 2026-05-29 12:12:54 +00:00
.idea scaffolding for ml pipeline 2026-05-16 14:15:56 +00:00
.vscode added utils to allow easier subtask management 2026-03-02 15:15:39 +00:00
applications move landlord overrides 2026-06-01 15:46:46 +00:00
asset_list Remove EPC and asset_list changes unrelated to SAL handler 2026-05-22 15:36:46 +00:00
backend Slice S0380.11: resolve zero-shower lodgings to count=0 (closes cert 2225) 2026-06-01 16:28:46 +00:00
backlog implemented onboarding 2026-04-21 20:23:33 +00:00
datatypes Slice S0380.11: resolve zero-shower lodgings to count=0 (closes cert 2225) 2026-06-01 16:28:46 +00:00
deployment/terraform added landlord description overrides 2026-05-29 12:12:54 +00:00
docs/adr move landlord overrides 2026-06-01 15:46:46 +00:00
domain docs: handover — start cert 0380 Summary → EPC → calculator path 2026-06-01 16:28:46 +00:00
epr_data_exports allowing carbon and energy otimisation by removing slack 2025-07-31 19:13:16 +01:00
etl added batch description and nonfunded measures 2026-05-27 10:30:19 +00:00
infrastructure move landlord overrides 2026-06-01 15:46:46 +00:00
model_data/requirements its working the way khalim wanted wiht postcode and then search that 2026-01-22 15:17:13 +00:00
orchestration moved classifier data transformation to an easy one 2026-06-01 14:53:34 +00:00
recommendations save 2026-05-07 15:55:44 +00:00
repositories move landlord overrides 2026-06-01 15:46:46 +00:00
scripts add address list 2026-05-21 15:30:03 +00:00
sfr/principal_pitch added added historic epc data class with shape 2026-05-08 12:03:35 +00:00
survey_report quidos site notes extraction 2025-02-18 19:49:29 +00:00
tests move landlord overrides 2026-06-01 15:46:46 +00:00
utilities get rid of comments 2026-05-20 13:21:11 +00:00
utils rename files in sharepoint to desired structure 2026-05-20 16:26:07 +00:00
.coveragerc fixed unit tests 2023-10-05 16:04:12 +01:00
.dockerignore deployment from infrastructure 2026-05-19 12:55:30 +00:00
.gitignore fixed merge conflicts from main 2026-05-26 11:21:09 +00:00
__init__.py added checking for directory before creation and made some minor style changes 2023-08-25 15:21:17 +01:00
ara_backend_design.md refactor: lift-and-shift packages/domain/src/domain/ml → domain/sap10_ml 2026-05-26 13:01:35 +00:00
BaseUtility.py fixed missing task and subtask for single remote assessments 2025-11-27 17:50:26 +00:00
CLAUDE.md fixed merge conflicts from main 2026-05-26 11:21:09 +00:00
conftest.py working on integrating new EPC api into address2UPRN 2026-04-27 11:32:44 +00:00
CONTEXT.md refactor: lift-and-shift packages/domain/src/domain/ml → domain/sap10_ml 2026-05-26 13:01:35 +00:00
devcontainer.sh add dev container 2026-04-17 14:50:57 +00:00
Dockerfile.test fix: address 22 project-wide test failures from previous sweep 2026-05-26 13:34:51 +00:00
Dockerfile.test.dockerignore deployment from infrastructure 2026-05-19 12:55:30 +00:00
Makefile adding to dev container to create shared network on start up 2026-04-25 15:03:07 +00:00
MEMORY.md memory 2026-04-02 10:24:31 +00:00
package-lock.json restructuring openUrpn code 2023-07-20 11:41:43 +01:00
package.json restructuring openUrpn code 2023-07-20 11:41:43 +01:00
pyproject.toml slice 14a: ml_training_data pkg + sample.py (CSV filter + random sample) 2026-05-16 17:39:43 +00:00
pyrightconfig.json slice 14d: build_features wires bulk reader -> mapper -> EpcMlTransform 2026-05-16 18:38:41 +00:00
pytest.ini refactor: lift-and-shift packages/domain/src/domain/ml → domain/sap10_ml 2026-05-26 13:01:35 +00:00
README.md adding to dev container to create shared network on start up 2026-04-25 15:03:07 +00:00
run_lambda_local.sh debugging local lambda run and updating the sap point checking condition 2023-09-13 18:47:12 +01:00
serverless.yml added logic to add to serverless 2026-04-22 12:39:44 +00:00
test.requirements.txt tests wrong environemnt 2026-05-29 16:17:06 +00:00
tox.ini removing playright install for integration test 2026-04-30 20:08:13 +00:00
UBIQUITOUS_LANGUAGE.md postcode_splitter: pure domain (UserAddress, sanitise_postcode, postcode_batching) 2026-05-19 16:45:47 +00:00

Model Repository

This repository contains the code pertaining to the development of the data science and machine learning products being utilised by Hestia.

The different folders in this repository relate to services that can be used independently, or can be imported and used as part of a larger application

Getting Started

Prerequisites

Dev Container Setup

This repo uses a Docker Compose-based dev container. The model-backend service joins a shared-dev Docker network so it can communicate with other local services (e.g. a frontend container) running on your machine.

VS Code users: The initializeCommand in devcontainer.json creates the shared-dev network automatically before the container starts. No manual step required — just open the repo and select Reopen in Container.

Non-VS Code / CI workflows: Run the following once before starting the container:

make dev-setup

This is idempotent and safe to re-run if the network already exists.

Folders

backend/

This folder contains the code for the fastapi backend service, which provides an interface to much of the functionality in this repository, for the frontend

model_data/

This folder contains related to the reading and preparation of assessment model data, including pulling out epc attributes

Testing

All tests can be run, against the configuration in pytest.ini running

pytest

This will run the complete panel of tests and report on coverage in the locations specified by the pytest.ini file.

To run tests in a specific service, e.g. inside of model_data, simply run

pytest --cov-config=model_data/.coveragerc --cov=model_data

This will produce the test results and coverage reports