Khalim Conn-Kowlessar 26998152a7 fix(mapper): read dropped detailed room-in-roof common-wall surfaces ... Follow-on to the slope/stud slice. A Detailed RR (RdSAP 10 §3.9.2) can also lodge `common_wall_*` — the wall separating the room-in-roof from the rest of the cold roof void. Those fields were undeclared → `from_dict` dropped them → `_api_rir_detailed_surfaces` omitted the common walls → the RR undercounted wall heat loss → over-rate. Fix: declare `common_wall_length/height_1/2` on `RoomInRoofDetails` (21_0_0 + 21_0_1) and build `kind="common_wall"` surfaces (raw L × H area to 2 d.p.). The cascade's Detailed-RR branch already bills common walls at the storey-below main-wall U (Table 4 p.22 "Common wall") and deducts their area from the §3.10.1 residual roof — no calculator change. No insulation thickness is read: common walls take the main-wall U, not a Table 17 RR-element U. 6 /tmp certs carry detailed `common_wall_length_1`: cohort mean|err| 2.43 -> 1.25 (all were over-rating; e.g. 2877-3059 +4.55 -> +2.79). Gauges: corpus within-0.5 67.5% -> 67.6% (MAE 0.987 -> 0.979); /tmp 71.6% -> 71.7% (MAE 0.846 -> 0.838). Harness 47/47 0 raised; regression = the 3 pre-existing fails; pyright net-zero (65=65). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>		2026-06-16 06:22:45 +00:00
..
tests	Slice 44: flat_roof_insulation_thickness mapper fix — surface lodged value on SapBuildingPart	2026-05-24 15:28:10 +00:00
__init__.py	first draft dataclasses with loading tests	2026-04-10 11:33:17 +00:00
common.py	first draft dataclasses with loading tests	2026-04-10 11:33:17 +00:00
helpers.py	slice 10.5: PhotovoltaicArray on SAP10 schema + EpcPropertyData	2026-05-16 16:00:25 +00:00
rdsap_schema_17_0.py	Map RdSAP-Schema-17.0 certs to EpcPropertyData 🟩	2026-06-12 12:45:19 +00:00
rdsap_schema_17_1.py	Dispatch and map RdSAP-Schema-17.1 certs end-to-end 🟩	2026-06-11 12:21:17 +00:00
rdsap_schema_18_0.py	Map Not-Defined glazing code to a valid type for windowless 18.0 certs 🟩	2026-06-11 11:55:46 +00:00
rdsap_schema_19_0.py	Map RdSAP-Schema-19.0 certs to EpcPropertyData 🟩	2026-06-12 12:29:36 +00:00
rdsap_schema_20_0_0.py	fix(mapper): handle 'ND' multiple_glazing_type on RdSAP-Schema-20.0.0	2026-06-15 06:43:55 +00:00
rdsap_schema_21_0_0.py	fix(mapper): read dropped detailed room-in-roof common-wall surfaces	2026-06-16 06:22:45 +00:00
rdsap_schema_21_0_1.py	fix(mapper): read dropped detailed room-in-roof common-wall surfaces	2026-06-16 06:22:45 +00:00