mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-27 23:35:01 +00:00
42ed6f8e46
RdSAP 10 §5.17 / Table 23. `wall_is_basement` is not a lodged U-value — it is a disambiguation flag selecting WHICH RdSAP default applies, so unlike wall/roof/floor_u_value it must survive the round-trip. Code 6 is canonically SYSTEM-BUILT and the gov-API path infers "basement" from a code-6 heuristic; the Elmhurst site-notes mapper sets wall_is_basement=False precisely to defeat it. Dropping the field inverted the answer — a system-built wall came back as a basement wall, dragging the whole ground floor onto the Table 23 basement-floor U-value via `has_basement`. Declared on no RdSAP schema, so it never arrives via the gov API; the earlier corpus scan showing 0 occurrences measured the wrong population. The Elmhurst site-notes path sets it and those EPCs are persisted (scripts/wchg_elmhurst_ingest.py). Nullable is load-bearing: None = "not stated, use the heuristic", False = "explicitly system-built, do not". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| abri | ||
| applications | ||
| backend | ||
| datatypes | ||
| domain | ||
| e2e | ||
| fixtures | ||
| harness | ||
| infrastructure | ||
| lambdas | ||
| magic_plan | ||
| orchestration | ||
| repositories | ||
| scripts | ||
| utilities | ||
| utils | ||
| __init__.py | ||
| conftest.py | ||
| test_lambda_packaging.py | ||