450e33e15d
A flat accessed via an unheated corridor/stairwell assumes a draught lobby is present, so SAP 10.2 §2 line (13) = 0.0 rather than the 0.05 no-lobby infiltration penalty. Per RdSAP 10 Specification (10-06-2025, p.30, "Draught lobby"): "add infiltration 0.05 if draught lobby is not present, or use 0.0 if present. ... Flat or maisonette: Assume draught lobby if entrance door is facing corridor (heated or unheated) or stairwell." Signal: a SHELTERED alternative wall (the RdSAP §5.9 wall-to-unheated-corridor surface) is the evidence that the flat's entrance faces a corridor — the same evidence the corridor door (Table 26 U=1.4) rides on. New helper `_has_sheltered_corridor_wall` factors that check out of `_corridor_door_count` and gates `_has_draught_lobby`. Houses and exposed-gable flats (no sheltered alt wall) keep the lodged value / "assume no lobby if cannot be determined" default, so the §2 cascade is unchanged for every non-corridor dwelling. The cascade previously added the 0.05 penalty unconditionally, over-counting (16)/(18)/(21) by 0.05 ACH. On simulated case 34 (cert 001431 storage flat) this lifted effective air change (25)m from the worksheet's monthly 0.572-0.638 to 0.574-0.668, over-counting space-heating demand (98) by +46.3 kWh/yr (+0.41%) -> SAP -0.18. Closing it lands (25)m exactly on the worksheet (avg 0.6024) and (98) at 11356.3 vs ws 11357.2: case 34 SAP 35.1325 -> 35.3130 vs ws 35.3094 (Δ -0.1769 -> +0.0036) Guard-rails held (both improved): worksheet harness 47/47, 0 divergers (the other corridor flat, cert 2474, -0.32 -> -0.02); API gauge 60.0% -> 60.1% within 0.5, mean|err| 1.167 -> 1.163. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .devcontainer | ||
| .github/workflows | ||
| .idea | ||
| .vscode | ||
| applications | ||
| asset_list | ||
| backend | ||
| backlog | ||
| datatypes | ||
| deployment/terraform | ||
| docs | ||
| domain | ||
| epr_data_exports | ||
| etl | ||
| infrastructure | ||
| model_data/requirements | ||
| orchestration | ||
| recommendations | ||
| repositories | ||
| sap worksheets | ||
| scripts | ||
| sfr/principal_pitch | ||
| survey_report | ||
| tests | ||
| utilities | ||
| utils | ||
| .coveragerc | ||
| .dockerignore | ||
| .gitignore | ||
| __init__.py | ||
| ara_backend_design.md | ||
| BaseUtility.py | ||
| CLAUDE.md | ||
| conftest.py | ||
| CONTEXT.md | ||
| devcontainer.sh | ||
| Dockerfile.test | ||
| Dockerfile.test.dockerignore | ||
| Makefile | ||
| MEMORY.md | ||
| package-lock.json | ||
| package.json | ||
| pyproject.toml | ||
| pyrightconfig.json | ||
| pytest.ini | ||
| README.md | ||
| run_lambda_local.sh | ||
| serverless.yml | ||
| test.requirements.txt | ||
| tox.ini | ||
| UBIQUITOUS_LANGUAGE.md | ||
Model Repository
This repository contains the code pertaining to the development of the data science and machine learning products being utilised by Hestia.
The different folders in this repository relate to services that can be used independently, or can be imported and used as part of a larger application
Getting Started
Prerequisites
Dev Container Setup
This repo uses a Docker Compose-based dev container. The model-backend service joins a shared-dev Docker network so it can communicate with other local services (e.g. a frontend container) running on your machine.
VS Code users: The initializeCommand in devcontainer.json creates the shared-dev network automatically before the container starts. No manual step required — just open the repo and select Reopen in Container.
Non-VS Code / CI workflows: Run the following once before starting the container:
make dev-setup
This is idempotent and safe to re-run if the network already exists.
Folders
backend/
This folder contains the code for the fastapi backend service, which provides an interface to much of the functionality in this repository, for the frontend
model_data/
This folder contains related to the reading and preparation of assessment model data, including pulling out epc attributes
Testing
All tests can be run, against the configuration in pytest.ini running
pytest
This will run the complete panel of tests and report on coverage in the locations specified by the pytest.ini file.
To run tests in a specific service, e.g. inside of model_data, simply run
pytest --cov-config=model_data/.coveragerc --cov=model_data
This will produce the test results and coverage reports