9694650abe
SAP 10.2 Table 3a (PDF p.160) additional combi loss (61)m. Two coupled defects, both surfaced by simulated case 49 (000565 + gas combi, U985 "Combi keep hot type = None") sitting at SAP 71.43 vs the worksheet's 72: 1. The cascade defaulted EVERY non-PCDB combi to the flat keep-hot time-clock row (600 × n/365). A combi WITHOUT a keep-hot facility uses row 1 (600 × fu × n/365, fu = V_d/100 when daily HW < 100 L/day) — over-counting (61)m for the no-keep-hot cohort. `water_heating_from_ cert` now defaults to the "without keep-hot" row. 2. `pcdb_combi_loss_override` returned None for keep_hot_facility=1/ timer=1, leaning on the OLD flat-600 default. So flipping the default silently turned 190 corpus PCDB keep-hot-time-clock combis into no-keep-hot. Fixed to return the flat keep-hot row EXPLICITLY. Key insight (the Summary is the input echo; the U985 keep-hot line is a computed OUTPUT, so it must be derivable): keep-hot rides on the PCDB boiler record (Table 105 keep_hot_facility/timer), resolved by `pcdb_combi_loss_override`. A generic SAP-code combi with no PCDB record (case 49, PCDF ref 0) has no keep-hot by construction → row 1. So the default is not a guess — it is the spec-correct value for non-PCDB combis. Worksheet-proven: case 49 → cost £726.696, SAP 72 — matching the accredited worksheet to the digit (continuous 71.6945 = the worksheet's own 71.6945). 000516 (keep-hot None) also exact (£860.716, SAP 63); 000490 (PCDB 10328, keep_hot_facility=1/timer=1) keeps its flat-600 via the PCDB path. Masked until now because every prior combi-loss worksheet fixture was keep-hot (000490/000474/000480 time-clock) or had V_d >= 100 every month (001431, rows coincide); case 49 is the first no-keep-hot one. Corpus within-0.5 72.7% -> 73.3%, MAE 0.781 -> 0.774, PE 3.5 -> 3.4; ratcheted _MAX_SAP_MAE 0.785 -> 0.775, _MAX_PE_PER_M2_MAE 3.6 -> 3.5. Note: pyright strict type gate not run locally (pyright not installed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .claude/skills | ||
| .devcontainer | ||
| .github/workflows | ||
| .idea | ||
| .vscode | ||
| applications | ||
| asset_list | ||
| backend | ||
| backlog | ||
| datatypes | ||
| deployment/terraform | ||
| docs | ||
| domain | ||
| epr_data_exports | ||
| etl | ||
| harness | ||
| infrastructure | ||
| model_data/requirements | ||
| orchestration | ||
| recommendations | ||
| repositories | ||
| sap worksheets | ||
| scripts | ||
| sfr/principal_pitch | ||
| survey_report | ||
| tests | ||
| utilities | ||
| utils | ||
| .coveragerc | ||
| .dockerignore | ||
| .gitignore | ||
| __init__.py | ||
| ara_backend_design.md | ||
| BaseUtility.py | ||
| CLAUDE.md | ||
| conftest.py | ||
| CONTEXT.md | ||
| devcontainer.sh | ||
| Dockerfile.test | ||
| Dockerfile.test.dockerignore | ||
| Makefile | ||
| MEMORY.md | ||
| next_claude_prompt.txt | ||
| P960-0001-001431-2.pdf | ||
| package-lock.json | ||
| package.json | ||
| playground.py.local-backup | ||
| pyproject.toml | ||
| pyrightconfig.json | ||
| pytest.ini | ||
| README.md | ||
| run_lambda_local.sh | ||
| serverless.yml | ||
| Summary_001431-3.pdf | ||
| test.requirements.txt | ||
| tox.ini | ||
| UBIQUITOUS_LANGUAGE.md | ||
Model Repository
This repository contains the code pertaining to the development of the data science and machine learning products being utilised by Hestia.
The different folders in this repository relate to services that can be used independently, or can be imported and used as part of a larger application
Getting Started
Prerequisites
Dev Container Setup
This repo uses a Docker Compose-based dev container. The model-backend service joins a shared-dev Docker network so it can communicate with other local services (e.g. a frontend container) running on your machine.
VS Code users: The initializeCommand in devcontainer.json creates the shared-dev network automatically before the container starts. No manual step required — just open the repo and select Reopen in Container.
Non-VS Code / CI workflows: Run the following once before starting the container:
make dev-setup
This is idempotent and safe to re-run if the network already exists.
Folders
backend/
This folder contains the code for the fastapi backend service, which provides an interface to much of the functionality in this repository, for the frontend
model_data/
This folder contains related to the reading and preparation of assessment model data, including pulling out epc attributes
Testing
All tests can be run, against the configuration in pytest.ini running
pytest
This will run the complete panel of tests and report on coverage in the locations specified by the pytest.ini file.
To run tests in a specific service, e.g. inside of model_data, simply run
pytest --cov-config=model_data/.coveragerc --cov=model_data
This will produce the test results and coverage reports