mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
0851b48807
_is_elmhurst_roof_window routed a vertical window (Location "External wall") to sap_roof_windows whenever its building part's roof type was a party ceiling (A "Another dwelling above" / NR "Non-residential space above"). That is right for an EXTENSION (cert 000565 Ext2/Ext4 score on worksheet (27a)) but wrong for the MAIN BP: a Main "A"/"NR" roof is the dwelling's own party ceiling — no external roof — so its windows are vertical. Gate the BP-roof-type rooflight rule to non-Main building parts. On a mid- floor flat (case 53 / cert 000565 re-keyed) the Main External-wall window is now vertical: its area deducts from the wall (was over-counted ~7 W/K) and it prices as a window. Summary-path SAP 74.0 -> 75.17, matching Elmhurst's accredited worksheet (75; space-heat 3408.6 vs 3408.58) — confirming the calculator is correct; the gap was the misclassification. 000565's extension rooflights, the "Roof of Room" branch, and the U>3.0 room-in-roof backstop are unchanged. gov-API path unaffected (it routes roof windows via window_wall_type==4). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| domain | ||
| loaders | ||
| schema | ||
| search | ||
| surveys | ||
| __init__.py | ||
| construction_age_band.py | ||
| efficiency.py | ||
| floor.py | ||
| fuel.py | ||
| heating_controls.py | ||
| hotwater.py | ||
| main_heating.py | ||
| property_type_built_form.py | ||
| roof.py | ||
| walls.py | ||
| windows.py | ||