Khalim Conn-Kowlessar b55b969b84 fix(water-heating): use lodged cylinder_heat_loss declared-loss factor ... The gov API lodges a manufacturer's declared cylinder loss factor (kWh/day) in `sap_heating.cylinder_heat_loss`, in which case it leaves the cylinder volume / insulation type / thickness None. That field was undeclared on the 21.0.x schemas, so `from_dict` dropped it — then `_cylinder_storage_loss_override` hit its insulation-None / volume-None guards and returned None, dropping the §4 storage loss ENTIRELY. The dwelling over-rated (the declared loss is typically ~1.5 kWh/day ≈ 550 kWh/yr). SAP 10.2 §4 branch a) (PDF p.136): when the declared loss factor is known, storage loss (50) = (48) declared loss × (49) Table-2b temperature factor — replacing the Table 2 V×L×VF computation. - declare `cylinder_heat_loss` on RdSapSchema21_0_0/21_0_1.SapHeating + EpcPropertyData.SapHeating; thread through the 21.0.x mappers. - `cylinder_storage_loss_monthly_kwh` gains `declared_loss_kwh_per_day`: when set, combined_55 = declared × TF (volume/insulation unused). - `_cylinder_storage_loss_override` resolves the declared loss BEFORE the insulation/volume guards (the gov omits those when the loss is lodged). 12 /tmp certs carry it (mean |err| 3.00 -> 2.51; the clean ones close hard, e.g. 2360 2.65 -> 0.30, 0245 2.25 -> 0.53). Corpus within-0.5 67.0% -> 67.3% (MAE 1.025 -> 1.020); /tmp 71.2% -> 71.4% (0.889 -> 0.882). Worksheet harness 47/47; regression = only the 3 pre-existing fails; pyright net-zero. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>		2026-06-16 05:27:47 +00:00
..
tests	Slice 44: flat_roof_insulation_thickness mapper fix — surface lodged value on SapBuildingPart	2026-05-24 15:28:10 +00:00
__init__.py	first draft dataclasses with loading tests	2026-04-10 11:33:17 +00:00
common.py	first draft dataclasses with loading tests	2026-04-10 11:33:17 +00:00
helpers.py	slice 10.5: PhotovoltaicArray on SAP10 schema + EpcPropertyData	2026-05-16 16:00:25 +00:00
rdsap_schema_17_0.py	Map RdSAP-Schema-17.0 certs to EpcPropertyData 🟩	2026-06-12 12:45:19 +00:00
rdsap_schema_17_1.py	Dispatch and map RdSAP-Schema-17.1 certs end-to-end 🟩	2026-06-11 12:21:17 +00:00
rdsap_schema_18_0.py	Map Not-Defined glazing code to a valid type for windowless 18.0 certs 🟩	2026-06-11 11:55:46 +00:00
rdsap_schema_19_0.py	Map RdSAP-Schema-19.0 certs to EpcPropertyData 🟩	2026-06-12 12:29:36 +00:00
rdsap_schema_20_0_0.py	fix(mapper): handle 'ND' multiple_glazing_type on RdSAP-Schema-20.0.0	2026-06-15 06:43:55 +00:00
rdsap_schema_21_0_0.py	fix(water-heating): use lodged cylinder_heat_loss declared-loss factor	2026-06-16 05:27:47 +00:00
rdsap_schema_21_0_1.py	fix(water-heating): use lodged cylinder_heat_loss declared-loss factor	2026-06-16 05:27:47 +00:00