junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
Model/packages
History
Khalim Conn-Kowlessar c40679d1e1 Slice 88: thread bp.floor_construction_type into u_floor cascade 
`u_floor` defaulted to the SOLID branch for age bands C+ when both
`construction` (int code) and `description` were None, regardless of
whether the bp's own `floor_construction_type` field said "Suspended
timber". This produced U=0.60 for cert 001479 Main vs the worksheet's
U=0.65 — a -0.05 W/m²K delta × 30.45 m² → -1.52 W/K of fabric loss
shortfall.

Fix: in `heat_transmission_section_from_cert`, prefer the bp's
`floor_construction_type` string over the global `epc.floors[].
description` when computing the per-bp floor U. The bp-level field
is the per-part lodgement Elmhurst surfaces in §3 / §9 of the
Summary; the global `epc.floors` list is often empty when the
mapper sources data from a Summary PDF rather than the full
RdSAP API JSON.

Impact on cert 001479 Summary → mapper → cascade SAP delta:
  BEFORE Slice 88: +0.2290 (floor U 0.60 vs target 0.65)
  AFTER  Slice 88: +0.0898 (floor exact match; only roof gap left)

Floor W/K breakdown for cert 001479 (mapper path):
  was:     21.6480  target 23.1705  delta -1.5225
  now:     23.1705  target 23.1705  delta +0.0000  ✓ EXACT

Cohort cascade pins remain GREEN (66 of 66) — the cohort hand-builts
already set `floor_construction_type` on their Main bp via the
Slice 72/75/78/82/85 Cat A bulk updates, so the new code path
applies the same suspended-timber branch that previous paths reached
via either explicit `floor_construction` int codes or the age-band
default (cohort certs are all age B which is in
`_SUSPENDED_TIMBER_DEFAULT_BANDS`, so they hit the suspended branch
either way; cert 001479 is age C and needs the explicit string).

Pyright net-zero on heat_transmission.py (13 → 13 errors).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 20:55:09 +00:00
..
domain Slice 88: thread bp.floor_construction_type into u_floor cascade 2026-05-25 20:55:09 +00:00
fetchers added potential file scaffolding: 2026-05-15 10:56:53 +00:00
repos added potential file scaffolding: 2026-05-15 10:56:53 +00:00
utils added potential file scaffolding: 2026-05-15 10:56:53 +00:00
README.md added potential file scaffolding: 2026-05-15 10:56:53 +00:00

README.md

Shared packages

Workspace packages consumed by services/*. Each package is its own Python distribution with its own pyproject.toml; services import via the workspace dependency mechanism ({ workspace = true }).

Package Purpose
domain/ Shared domain types — Property, BaselinePerformance, Plan, Scenario, EpcPropertyData, etc. No persistence, no IO, no business logic.
repos/ Persistence layer — one repo per aggregate. Owns the SQL. Depends on domain.
fetchers/ External API clients (gov EPC, Ofgem, Google Solar, etc.). Depend on domain for response shapes.
utils/ Cross-cutting infra — logging, S3, CloudWatch URL builders, SQS task helpers.

Adding a new shared package

Only when a real second consumer materialises. Don't pre-shatter (repos-epc, repos-property, ...) — split when a deployment needs to drop a dep, not before.

See ../ara_backend_design.md §11 for the broader monorepo layout and ../CONTEXT.md for the domain glossary that names the types living in domain/.