mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
c40679d1e1
`u_floor` defaulted to the SOLID branch for age bands C+ when both `construction` (int code) and `description` were None, regardless of whether the bp's own `floor_construction_type` field said "Suspended timber". This produced U=0.60 for cert 001479 Main vs the worksheet's U=0.65 — a -0.05 W/m²K delta × 30.45 m² → -1.52 W/K of fabric loss shortfall. Fix: in `heat_transmission_section_from_cert`, prefer the bp's `floor_construction_type` string over the global `epc.floors[]. description` when computing the per-bp floor U. The bp-level field is the per-part lodgement Elmhurst surfaces in §3 / §9 of the Summary; the global `epc.floors` list is often empty when the mapper sources data from a Summary PDF rather than the full RdSAP API JSON. Impact on cert 001479 Summary → mapper → cascade SAP delta: BEFORE Slice 88: +0.2290 (floor U 0.60 vs target 0.65) AFTER Slice 88: +0.0898 (floor exact match; only roof gap left) Floor W/K breakdown for cert 001479 (mapper path): was: 21.6480 target 23.1705 delta -1.5225 now: 23.1705 target 23.1705 delta +0.0000 ✓ EXACT Cohort cascade pins remain GREEN (66 of 66) — the cohort hand-builts already set `floor_construction_type` on their Main bp via the Slice 72/75/78/82/85 Cat A bulk updates, so the new code path applies the same suspended-timber branch that previous paths reached via either explicit `floor_construction` int codes or the age-band default (cohort certs are all age B which is in `_SUSPENDED_TIMBER_DEFAULT_BANDS`, so they hit the suspended branch either way; cert 001479 is age C and needs the explicit string). Pyright net-zero on heat_transmission.py (13 → 13 errors). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| src/domain | ||
| pyproject.toml | ||
| README.md | ||
domna-domain
Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.
Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.
Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.
Layout
src/domain/
├── __init__.py
├── property.py # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py # Plan, PlanPhase, OptimisedPackage
├── scenario.py # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
├── __init__.py
├── transform.py # EpcMlTransform (versioned per §8.3)
└── schema.py
When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.