junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
7623 commits 49 branches 0 tags 224 MiB
Commit graph

7623 commits

This branch
This branch
All branches
Author SHA1 Message Date
Daniel Roth
e363a1105a Abri amend_job omits the surveyor resource so amendments cannot clobber Abri-side reassignments 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 16:21:06 +00:00
Daniel Roth
b70afc8d9d Abri amend_job omits the surveyor resource so amendments cannot clobber Abri-side reassignments 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 16:20:41 +00:00
Daniel Roth
7bdba469fb Abri amend_job serialises the spec's amendoptiappt envelope with the surveyor resource last 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 16:19:16 +00:00
Daniel Roth
fbb4345116 Abri amend_job serialises the spec's amendoptiappt envelope with the surveyor resource last 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 16:18:24 +00:00
Daniel Roth
c542a57ae5 Abri amend_job amends an OpenHousing appointment and returns the echoed booking 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 16:17:41 +00:00
Daniel Roth
2cfed0c33d Abri amend_job amends an OpenHousing appointment and returns the echoed booking 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 16:15:44 +00:00
Daniel Roth
6a7cc68c9a Merge branch 'main' into feature/abri-api-integration 2026-07-03 16:00:18 +00:00
Daniel Roth
c0d36d1e67
Merge pull request #1458 from Hestia-Homes/feature/abri-api-integration 
Abri DomnaRelay client — foundation + LogJob vertical (strictly typed)
 2026-07-03 16:49:46 +01:00
Jun-te Kim
838668bfdb
Merge pull request #1451 from Hestia-Homes/fix/sap-heating-optional-air-conditioning 
Make nested SapHeating.has_fixed_air_conditioning optional across all RdSAP schemas
 2026-07-03 16:34:27 +01:00
Jun-te Kim
6172f5d30d
Merge pull request #1452 from Hestia-Homes/fix/roof-construction-another-premises-above 
Map API roof_construction code 9 ("another premises above") to None
 2026-07-03 16:34:15 +01:00
Daniel Roth
ff868156d1 Abri job logging trigger is named after the DomnaRelay route it fires 🟪 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 15:26:41 +00:00
Daniel Roth
a86607e420 Abri relay exchange reads as serialise, post, parse, then dispatch on the failure document 🟪 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 15:12:44 +00:00
Jun-te Kim
d769f4488a Suppress roof heat loss for API roof_construction codes 7 and 9 
RdSAP 10 Specification (10-06-2025) §5.2.5: "If a dwelling or part of a
dwelling has commercial premises above record as another dwelling
above" — so code 9 ("another premises above") must get the same
zero-heat-loss treatment as code 7 ("another dwelling above"), per the
spec's own "there is no heat loss through the roof of a building part
that has the same dwelling above or another dwelling above."

The previous fix mapped both to None, which only avoided the mapper
crash — it didn't achieve zero heat loss. heat_transmission.py's
per-part suppression (part_roof_is_party) only fires when
roof_construction_type CONTAINS the literal string "another dwelling
above"; that string was only ever set on the Elmhurst ingestion path.
The API path mapped 7 (and, until now, 9) to None, so the suppression
never fired for any API-derived cert — has_exposed_roof (the
dwelling_type-label-only fallback) was the sole gate, with no way to
know about a per-part party-ceiling lodgement. Both codes now map to
"(another dwelling above)" so the existing suppression logic fires on
both ingestion paths, matching what
domain/epc/property_overrides/roof_party_ceiling_guard.py already does
independently for the landlord-override pipeline (same spec citation).

Verified against the motivating cert (uprn 10013320122): roof_w_per_k
now correctly computes to 0.0. Full RdSAP-21.0.1 corpus (1000 certs)
re-run: within-0.5 unchanged at 77.8%, MAE improves marginally
(0.6364 vs 0.637 ceiling) — no regression.
 2026-07-03 14:44:01 +00:00
Daniel Roth
32b56050b0 Abri relay requests share one envelope, transport and rejection path across request types 🟪 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:37:40 +00:00
Daniel Roth
c23c74be6b Abri log_job treats a logged-job response missing its job number as retriable 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:36:55 +00:00
Daniel Roth
c1c2a1947e Abri log_job treats a logged-job response missing its job number as retriable 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:35:35 +00:00
Daniel Roth
62ad53df5a Abri relay credentials and defaults hydrate from environment configuration 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:34:53 +00:00
Daniel Roth
39055bafed Abri relay credentials and defaults hydrate from environment configuration 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:34:27 +00:00
Daniel Roth
f5fefd4d93 Abri job descriptions identify the visit as a Domna condition survey 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:34:05 +00:00
Daniel Roth
caffa5c4e1 Abri job descriptions identify the visit as a Domna condition survey 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:33:40 +00:00
Daniel Roth
2c660bdb5d Abri unparseable confirmed time fails loudly rather than silently booking all day 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:33:12 +00:00
Daniel Roth
eccc03f9f2 Abri confirmed time at or after midday books the afternoon slot 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:32:49 +00:00
Daniel Roth
cd29cbb0b8 Abri confirmed time before midday books the morning slot 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:32:15 +00:00
Daniel Roth
fcdab30b73 Abri confirmed time before midday books the morning slot 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:31:51 +00:00
Daniel Roth
992ac243ba Abri booking with no confirmed time books an all-day appointment 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:31:33 +00:00
Daniel Roth
da4caea407 Abri booking with no confirmed time books an all-day appointment 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:31:12 +00:00
Daniel Roth
fef69145da Abri log_job treats an unexpectedly shaped relay response as retriable 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:30:29 +00:00
Daniel Roth
a325f65bf0 Abri log_job treats an unexpectedly shaped relay response as retriable 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:30:02 +00:00
Daniel Roth
0df1d866fe Abri log_job treats a malformed relay response as retriable, never as success or rejection 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:29:41 +00:00
Daniel Roth
ff34872c24 Abri log_job treats a malformed relay response as retriable, never as success or rejection 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:29:08 +00:00
Daniel Roth
95bb951b60 Abri log_job raises a retriable transport error when the relay is unreachable 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:28:39 +00:00
Daniel Roth
6b9f5a0140 Abri log_job raises a retriable transport error when the relay is unreachable 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:28:19 +00:00
Daniel Roth
d002a3defc Abri log_job raises a retriable transport error on an HTTP error status 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:27:43 +00:00
Daniel Roth
9fefdf81aa Abri log_job raises a retriable transport error on an HTTP error status 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:27:14 +00:00
Daniel Roth
e0830169ad Abri log_job surfaces an OpenHousing rejection as a typed result with verbatim code and message 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:26:23 +00:00
Daniel Roth
e473ea8a4f Abri log_job surfaces an OpenHousing rejection as a typed result with verbatim code and message 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:25:49 +00:00
Daniel Roth
79ce9dc4b1 Abri log_job sends the spec's recorded LogJob envelope to the relay endpoint 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:24:57 +00:00
Daniel Roth
4803ae40e1 Abri log_job sends the spec's recorded LogJob envelope to the relay endpoint 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:23:42 +00:00
Daniel Roth
dd451a03a8 Abri log_job returns the OpenHousing job number from the relay success response 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:22:56 +00:00
Daniel Roth
b22afcde9f Abri log_job returns the OpenHousing job number from the relay success response 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 14:22:09 +00:00
Daniel Roth
41d46e3910
Merge pull request #1454 from Hestia-Homes/feature/extend-sharepoint-renamer 
Extend sharepoint renamer to work for batch subfolders
 2026-07-03 14:48:07 +01:00
Daniel Roth
7852928181 delete test data file 2026-07-03 13:38:09 +00:00
Daniel Roth
0c3fbe5853 rename dodgy address 2026-07-03 13:37:58 +00:00
Jun-te Kim
71b970a697 Map API roof_construction code 9 ("another premises above") to None 
Same party-ceiling semantics as the already-mapped code 7 ("another
dwelling above" / "same dwelling above") — the unit has no exposed
roof, so there's nothing for the cascade to compute a U-value for.
Confirmed against the live cert (uprn 10013320122): roofs[].description
= "(another premises above)", roof_insulation_location = "ND" (the
codebase's established "no exposed roof" signal).

Surfaced by 1 failed modelling_e2e subtask on portfolio 817
(task_source='modelling_e2e', job_completed > '2026-07-03 12:50:37.555+01:00').
 2026-07-03 13:24:10 +00:00
Jun-te Kim
1144b1e7b1 Make nested SapHeating.has_fixed_air_conditioning optional across all RdSAP schemas 
Some lodged certs omit the sap_heating.has_fixed_air_conditioning key,
which the generic from_dict loader treats as a required field and
rejects outright. Two prior commits (26651ca71, 8074f4152) fixed the
duplicate top-level field of the same name but left this nested copy
untouched; a third pass (44991bed0) missed it too. The mapper already
reads it defensively (== "true", which is False on None), so this is
a safe default.

Surfaced by 7 failed modelling_e2e subtasks on portfolio 817.
 2026-07-03 13:09:17 +00:00
Jun-te Kim
f629b42bd2
Merge pull request #1448 from Hestia-Homes/fix/full-sap-export-capable-mapping 
Full-SAP certs carry their lodged PV export-capability flag (WS3 of #1435)
 2026-07-03 13:32:53 +01:00
Jun-te Kim
23ebd5e637
Merge pull request #1446 from Hestia-Homes/fix/ashp-size-to-dwelling-heat-loss 
Size the ASHP to the dwelling's design heat loss (fix undersized fixed pump scoring below baseline)
 2026-07-03 13:32:30 +01:00
Daniel Roth
dc188ca3c5 SharePoint 404s raise ResourceNotFoundError without error-level logging 🟩 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 12:26:33 +00:00
Khalim Conn-Kowlessar
4fcd23455b The multi-measure trigger fixture is a cert the sized ASHP alone cannot clear 🟩 
Golden cert 0330 now reaches band C on the dwelling-sized ASHP alone
(ADR-0049), dropping its solid_floor_insulation companion; cert 0390
still fires three measures, so the per-measure trigger-attribute
assertions move there (and gain the lighting triggers).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-07-03 12:25:03 +00:00
Daniel Roth
4a71c555fa SharePoint 404s raise ResourceNotFoundError without error-level logging 🟥 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-03 12:22:26 +00:00